Merge pull request #883 from alphagov/PP-6850-add-missing-transaction…

…dao-test PP-6850 Add TransactionDao test
alphagov · Aug 12, 2020 · d8f3aa8 · d8f3aa8
2 parents c5e6787 + 915385f
commit d8f3aa8
Showing 1 changed file with 24 additions and 0 deletions.
diff --git a/src/test/java/uk/gov/pay/ledger/transaction/dao/TransactionDaoIT.java b/src/test/java/uk/gov/pay/ledger/transaction/dao/TransactionDaoIT.java
@@ -287,7 +287,31 @@ public void findTransactionByParentIdAndGatewayAccountId_shouldFilterByParentExt
         TransactionEntity transactionEntity = transactionEntityList.get(0);
 
         assertThat(transactionEntity.getId(), is(transactionWithParentExternalId.getId()));
+    }
+
+    @Test
+    public void findTransactionByParentId_shouldFilterByParentExternalId() {
+        TransactionEntity transaction1 = aTransactionFixture()
+                .withState(TransactionState.CREATED)
+                .withTransactionType("PAYMENT")
+                .insert(rule.getJdbi())
+                .toEntity();
+
+        TransactionEntity transactionWithParentExternalId = aTransactionFixture()
+                .withState(TransactionState.SUBMITTED)
+                .withTransactionType("REFUND")
+                .withGatewayAccountId(transaction1.getGatewayAccountId())
+                .withParentExternalId(transaction1.getExternalId())
+                .insert(rule.getJdbi())
+                .toEntity();
 
+        List<TransactionEntity> transactionEntityList =
+                transactionDao.findTransactionByParentId(transactionWithParentExternalId.getParentExternalId());
+
+        assertThat(transactionEntityList.size(), is(1));
+        TransactionEntity transactionEntity = transactionEntityList.get(0);
+
+        assertThat(transactionEntity.getId(), is(transactionWithParentExternalId.getId()));
     }
 
     @Test