Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-11279: Connector-adminusers messaging pact test #4837

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

oswaldquek
Copy link
Contributor

@oswaldquek oswaldquek commented Nov 15, 2023

A connector (consumer) to adminusers (provider) messaging pact test for a "service_archived" event placed on the connector tasks queue.

The ConnectorQueueMessageContractTest on the adminusers side can be seen to be passing in the adminusers-provider-pact-verification build 🎉

@oswaldquek oswaldquek force-pushed the PP-11279-adminusers-connector-message-pact-test branch 3 times, most recently from 03f3dd2 to e9d2f56 Compare November 15, 2023 18:15
@oswaldquek oswaldquek marked this pull request as ready for review November 15, 2023 18:16
oswaldquek added a commit to alphagov/pay-adminusers that referenced this pull request Nov 16, 2023
* PP-11279: Run the connector-adminusers messaging pact test

This is safe to merge now as there is no published pact where the provider is adminusers and consumer is connector tagged with "master" and above (i.e. "test-fargate", "staging-fargate" etc). For reference the pact to be published is at alphagov/pay-connector#4837.
oswaldquek added a commit to alphagov/pay-ci that referenced this pull request Nov 16, 2023
…rovider

This is because we now have a [messaging pact
test](alphagov/pay-connector#4837) where connector is
the consumer and adminusers is the provider.
oswaldquek added a commit to alphagov/pay-ci that referenced this pull request Nov 16, 2023
…rovider (#967)

This is because we now have a [messaging pact
test](alphagov/pay-connector#4837) where connector is
the consumer and adminusers is the provider.
A connector (consumer) to adminusers (provider) messaging pact test for a
"service_archived" event placed on the connector tasks queue.
@oswaldquek oswaldquek force-pushed the PP-11279-adminusers-connector-message-pact-test branch from e9d2f56 to 680f7f3 Compare November 16, 2023 17:03
Copy link
Contributor

@stephencdaly stephencdaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oswaldquek oswaldquek merged commit 9195ad3 into master Nov 16, 2023
2 checks passed
@oswaldquek oswaldquek deleted the PP-11279-adminusers-connector-message-pact-test branch November 16, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants