Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-11811 Update DAO method to find services to archive #2261

Merged
merged 1 commit into from
Nov 21, 2023
Merged

PP-11811 Update DAO method to find services to archive #2261

merged 1 commit into from
Nov 21, 2023

Conversation

kbottla
Copy link
Contributor

@kbottla kbottla commented Nov 20, 2023 •
edited
Loading

WHAT

  • Update the DAO method to use new date fields to select services for archiving

@kbottla
PP-11205 Update DAO method to find services to archive
1dde7eb 
- Update the DAO method to use new date fields to select services for archiving

  The full criteria to select services are as follows:
   1. created_date is older than archive before data
   2. created_date and first_checked_for_archival_date are null. These will be for historical services without created_date and never have been processed by the expunge task
   3. first_checked_for_archival_date is older than the archive before data. This date is set by expunge task on first checking the service for archival and will be used where created_date is not available
   4. Additionally `skip_checking_for_archival_until_date` is null or older than the current date. This is to skip checking active services for archival on every task run
@kbottla kbottla force-pushed the pp_11205_update_dao branch from cc42e7e to 1dde7eb Compare November 20, 2023 14:55
@kbottla kbottla marked this pull request as ready for review November 20, 2023 14:58
@kbottla kbottla changed the title PP-11205 Update DAO method to find services to archive PP-11811 Update DAO method to find services to archive Nov 20, 2023
@kbottla kbottla merged commit a6ece1d into master Nov 21, 2023
2 checks passed
@kbottla kbottla deleted the pp_11205_update_dao branch November 21, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfharden jfharden jfharden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbottla @jfharden