Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-11205 Add method to search Ledger transactions #2213

Merged
merged 2 commits into from
Nov 1, 2023
Merged

PP-11205 Add method to search Ledger transactions #2213

merged 2 commits into from
Nov 1, 2023

Conversation

kbottla
Copy link
Contributor

@kbottla kbottla commented Oct 31, 2023

WHAT YOU DID

  • Added service method to search transactions for a gateway account.
  • This will be used to find the last transaction for the service and archive service if no payments have been taken in the last 7 years

@kbottla
PP-11205 Add method to search Ledger transactions
ac96313 
- Added service method to search transactions for a gateway account.
- This will be used to find the last transaction for the service and archive service if no payments have been taken in the last 7 years
@kbottla kbottla force-pushed the pp_11205_add_ledger_method branch from 097c5a9 to ac96313 Compare October 31, 2023 20:59
@kbottla kbottla marked this pull request as ready for review November 1, 2023 08:17
oswaldquek
oswaldquek requested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@oswaldquek oswaldquek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and comments

src/main/java/uk/gov/pay/adminusers/client/ledger/model/LedgerSearchTransactionsResponse.java Outdated Show resolved Hide resolved
src/main/java/uk/gov/pay/adminusers/client/ledger/service/LedgerService.java Show resolved Hide resolved
src/test/java/uk/gov/pay/adminusers/client/ledger/service/LedgerServiceTest.java Outdated Show resolved Hide resolved
src/test/java/uk/gov/pay/adminusers/client/ledger/service/LedgerServiceTest.java Outdated Show resolved Hide resolved
src/test/java/uk/gov/pay/adminusers/client/ledger/service/LedgerServiceTest.java Outdated Show resolved Hide resolved
@kbottla kbottla merged commit 29a0623 into master Nov 1, 2023
2 checks passed
@kbottla kbottla deleted the pp_11205_add_ledger_method branch November 1, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oswaldquek oswaldquek oswaldquek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbottla @oswaldquek