BAU — Tell Dependabot to ignore Guice 6 and Dropwizard Sentry 4 #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tell Dependabot to ignore Guice 6.x and Dropwizard Sentry 4.x because neither of these are going to be just-merge-the- Dependabot-PR upgrades: • Guice 6.x requires compatibility work on our side while Guice 7.x only works with Jakarta EE and not Java EE • We essentially forked Dropwizard Sentry because it did not support Dropwizard 3.x — there is now a Dropwizard Sentry 4.x, which supports Dropwizard 4.x (and maybe Dropwizard 3.x), but we’d need to do work to go back to using an unmodified version Also add comments explaining why we’re ignoring upgrades for certain Maven dependencies.
alexbishop1
force-pushed
the
bau_tell_dependabot_to_ignore_guice_6_and_dropwizard_sentry_4
branch
from
5b3c8f4 to
6bd53f3
Compare
katstevens
approved these changes
Oct 27, 2023
alexbishop1
deleted the
bau_tell_dependabot_to_ignore_guice_6_and_dropwizard_sentry_4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tell Dependabot to ignore Guice 6.x and Dropwizard Sentry 4.x because neither of these are going to be just-merge-the-Dependabot-PR upgrades:
Also add comments explaining why we’re ignoring upgrades for certain Maven dependencies.