Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BAU — Small tweaks to POM and Dependabot config #2191

Merged
merged 1 commit into from
Oct 26, 2023
Merged

BAU — Small tweaks to POM and Dependabot config #2191

merged 1 commit into from
Oct 26, 2023

Conversation

alexbishop1
Copy link
Contributor

@alexbishop1 alexbishop1 commented Oct 25, 2023 •
edited
Loading

  • Use Dropwizard version property so we upgrade Dropwizard and Dropwizard Testing Support for JUnit 4.x in lockstep
  • Use Testcontainers BOM
  • Stop using EclipseLink version property because it’s only used in one place
  • Remove unused Guice version property
  • Tell Dependabot not to try to upgrade us to Guice 7.0.0, which migrates from Java EE to Jakarta EE and is never going to be a just-merge-it upgrade

@alexbishop1
BAU — Small tweaks to POM and Dependabot config
81228c6 
• Use Dropwizard version property so we upgrade Dropwizard and
  Dropwizard Testing Support for JUnit 4.x in lockstep

• Use Testcontainers BOM

• Stop using EclipseLink version property because it’s only used in
  one place

• Remove unused Guice version property

• Tell Dependabot not to try to upgrade us to Guice 7.0.0, which
  migrates from Java EE to Jakarta EE and is never going to be a
  just-merge-it upgrade
@alexbishop1 alexbishop1 force-pushed the bau_small_tweaks_to_pom_and_dependabot_config branch from aa46404 to 81228c6 Compare October 26, 2023 09:46
SandorArpa
SandorArpa approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@SandorArpa SandorArpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexbishop1 alexbishop1 merged commit 3dd720f into master Oct 26, 2023
2 checks passed
@alexbishop1 alexbishop1 deleted the bau_small_tweaks_to_pom_and_dependabot_config branch October 26, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SandorArpa SandorArpa SandorArpa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexbishop1 @SandorArpa