PP-11652 Stop Dependabot trying to upgrade us to Dropwizard 4 #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katstevens
reviewed
Oct 17, 2023
.github/dependabot.yml
Outdated
| ignore: | ||
| - dependency-name: "dropwizard-dependencies" | ||
| versions: | ||
| - "> 3" |
There was a problem hiding this comment.
I think you're better off doing ">= 4" otherwise it won't pick up minor versions of 3.
Also I've just realised I've done the Docker ignores wrong on some other repos 🙀
There was a problem hiding this comment.
I copied from another file!
We’d rather Dependabot not try to upgrade Dropwizard at all unless it’s a security fix but it’s not possible to have Dependabot only open security fix pull requests for Java projects. Dependabot 4 is a major release that switches from the deprecated Java EE to Jakarta EE. This will involve other changes to our code so we’re never going to just merge a Dependabot PR and be done with it. So if Dependabot is going to insist on opening Dropwizard upgrade PRs, it may as well open ones we might actually merge (such as upgrading from 3.0.1 to 3.0.2 — which it would not open while it sees a ‘newer’ 4.x version is available).
alexbishop1
force-pushed
the
PP-11652_stop_dependabot_trying_to_upgrade_us_to_dropwizard_4
branch
from
1dad274 to
ba73eb4
Compare
katstevens
approved these changes
Oct 17, 2023
alexbishop1
deleted the
PP-11652_stop_dependabot_trying_to_upgrade_us_to_dropwizard_4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We’d rather Dependabot not try to upgrade Dropwizard at all unless it’s a security fix but it’s not possible to have Dependabot only open security fix pull requests for Java projects.
Dependabot 4 is a major release that switches from the deprecated Java EE to Jakarta EE. This will involve other changes to our code so we’re never going to just merge a Dependabot PR and be done with it.
So if Dependabot is going to insist on opening Dropwizard upgrade PRs, it may as well open ones we might actually merge (such as upgrading from 3.0.1 to 3.0.2 — which it would not open while it sees a ‘newer’ 4.x version is available).