Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-11548: Update prometheus initialisation #2152

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

jfharden
Copy link
Contributor

WHAT YOU DID

Now we don't need to build our default labels in the app (since they are now added by the sidecar) we should remove the default sample builder.

  1. Remove default sample builder
  2. Update local build script to account for m1 macs, and use the correct container tag

How to test

This change has already been rolled out to connector and is working well.

Code review checklist

Logging

  • only emit log lines at ERROR level which require immediate attention from a support engineer. These will trigger a zendesk alert.

Documentation

  • Updated README.md for any of the following ?
  • Introduced any new environment variables / removed existing environment variable
  • Added new API / updated existing API definition

@jfharden jfharden merged commit 5973097 into master Sep 19, 2023
2 checks passed
@jfharden jfharden deleted the pp-11548/update-prometheus-init branch September 19, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants