Add Travis config to run linkchecker against the built site #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's been necessary to pin an older version of requests due to an issue with the version checking in linkchecker.
To build the site and run linkchecker over the result.
This was tripping up linkchecker.
The content that included this image was removed in 710a4bf.
alext
changed the title
samcrang
reviewed
Nov 22, 2017
| @@ -18,3 +18,7 @@ six==1.10.0 | |||
| tornado==4.3 | |||
| webcolors==1.5 | |||
| wsgiref==0.1.2 | |||
|
|
|||
| linkchecker==9.3 | |||
There was a problem hiding this comment.
The linkchecker project currently seems to be in a weird state—supposedly the project is dead and has been picked up by a new group but they still haven't released anything on PyPI yet.
Does using this seemingly dead project seem like a problem?
There was a problem hiding this comment.
We're already using this for the tech docs, so I chose to use it here for consistency. I agree that it's in a wierd state, but I think we should address that across everything separately if that becomes an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Run linkchecker against the built site so that we catch any broken links etc.
This fixes a couple of broken links that were found as a result.
I've also cleaned up an unused image that was missed in #159
How to review
Who can review
Not me.