remove AssertionErrors #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if your provided JWT token is missing either the 'iss' or 'iat' fields, we now raise TokenIssuerError or TokenIssuedAtError respectively, rather than AssertionErrors
replacing AssertionError with TokenDecodeError changes the signature of our auth functions - if the user is expecting an AssertionError this is a breaking change
1 task
quis
previously requested changes
Nov 7, 2016
|
@quis iat test is found in admin app, since i wanted to make sure i was also capturing our authhandler's logic alphagov/notifications-api@f089b75#diff-707b2a6eab3566cfd44abdb93239c959R67 |
in practice we get the issuer before we decode the token so a bad method invocation was not caught by notifications-api tests, so ensure that the decode_jwt_token method is well tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace AssertionErrors with new TokenDecodeError subclasses
if your provided JWT token is missing either the 'iss' or 'iat' fields,
we now raise TokenIssuerError or TokenIssuedAtError respectively,
rather than AssertionErrors