Skip to content

Commit

Permalink
Add Brakeman as a dependency
Browse files Browse the repository at this point in the history
This will allow us to use the version of Brakeman specified in the
`Gemfile.lock` for the project rather than the version manually
installed onto the CI or our local machines. Currently we can't do this
because most of our apps don't have Brakeman listed as a dependency.

This will make it easier to run Brakeman locally when debugging security
issues that get flagged by the tool, but should also make the CI run
more reliable as all we need to do is run `bundle exec brakeman` which
is easier to understand and less complex than the current method (of
manually installing Brakeman first into a directory and running it from
there).

I'm also hoping this will fix an intermittent problem we have where
sometimes Brakeman will fail to run correctly in CI as it hasn't been
installed properly.
  • Loading branch information
thomasleese committed Oct 15, 2019
1 parent 4fd3f08 commit 7e96d57
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions govuk_test.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Gem::Specification.new do |spec|
spec.add_dependency "webdrivers", ">= 4"
spec.add_dependency "puma"
spec.add_dependency "selenium-webdriver", ">= 3.142"
spec.add_dependency "brakeman", "~> 4.6"

spec.add_development_dependency "bundler", "~> 1.16"
spec.add_development_dependency "rake", "~> 10.0"
Expand Down

0 comments on commit 7e96d57

Please sign in to comment.