Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update brakeman to fix false positive warning
We recently came across a [strange warning][0] in a `frontend` build: ``` == Warnings == Confidence: High Category: Cross-Site Scripting Check: SanitizeMethods Message: loofah gem 2.10.0 is vulnerable (CVE-2018-8048). Upgrade to 2.2.1 File: Gemfile.lock Line: 187 ``` Version 2.10.0 is clearly more recent than 2.2.1. This came from how brakeman was doing a check: ``` loofah_version and loofah_version < "2.2.1" ``` but in ruby `'2.10.0' < '2.2.1'` is true: ``` [2] pry(main)> '2.10.0' < '2.2.1' => true ``` This [has been fixed][1] in [version 5.0.2][2] so let's upgrade brakeman to this new version. [0]: https://ci.integration.publishing.service.gov.uk/job/frontend/job/update-rubocop/6/console [1]: https://github.com/presidentbeef/brakeman/pull/1607/files [2]: https://github.com/presidentbeef/brakeman/blob/main/CHANGES.md#502---2021-06-07
- Loading branch information