Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix django package #319

Merged
merged 2 commits into from
Jul 13, 2017
Merged

Fix django package #319

merged 2 commits into from
Jul 13, 2017

Conversation

robyoung
Copy link
Contributor

This is made up of two parts.

Include assets in Django Python package

setuptools will not look for a MANIFEST.in unless the include_package_data flag is set to True.

This is described in the setuptools documentation

And in a slightly easier to understand way in the Flask docs

Fix the download_url

The release tags have a v prepended to the version.

robyoung added 2 commits July 12, 2017 16:52
setuptools will not look for a `MANIFEST.in` unless the
`include_package_data` flag is set to `True`.

This is described in the setuptools documentation
http://setuptools.readthedocs.io/en/latest/setuptools.html?highlight=include_package_data#including-data-files

And in a slightly easier to understand way in the Flask docs
http://flask.pocoo.org/docs/0.12/patterns/distribute/#basic-setup-script
The release tags have a v prepended to the version.
@gemmaleigh gemmaleigh requested a review from 36degrees July 13, 2017 09:31
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this!

I don't know much about Python or Django but the commit messages are detailed and overall it makes sense to me.

@36degrees 36degrees merged commit 3cce938 into alphagov:master Jul 13, 2017
@robyoung robyoung deleted the fix-django-package branch July 13, 2017 09:43
@robyoung
Copy link
Contributor Author

Ace, thanks. Could you push a rebuilt 0.22.2 python package (ie. this one) to github releases as well please?

That would mean that we can install straight from the URL.

@36degrees
Copy link
Contributor

#320 should take care of that when it's merged.

@robyoung
Copy link
Contributor Author

Ahh, perfect! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants