-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate unique items for arrays with the "uniqueItems" property #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This re-calculates the values of an array if the "uniqueItems" property is set and a non-unique item has been generated. This has been to help resolve flaky tests that expect a random array and occasionally fail due to the generation of an array with collisions. As there is a risk that this can produce an eternal loop I've put in a check that if there are very number of attempts to generate the unique value then it should abort. This does produce a risk of failure if there is a low amount of variance in the allowed variables. This is to resolve issues such as: ``` GovukSchemas::InvalidContentGenerated: An invalid content item was generated. This probably means there's a bug in the generator that causes it to output invalid values. Below you'll find the generated payload, the validation errors and the schema that was used. ... Validation errors: -------------------------- [ { "schema": "869a7d30-f94e-5044-84e7-dc3c01c8f1ba#", "fragment": "#/details/featured_attachments", "message": "The property '#/details/featured_attachments' contained duplicated array values in schema 869a7d30-f94e-5044-84e7-dc3c01c8f1ba#", "failed_attribute": "UniqueItems" }, { "schema": "869a7d30-f94e-5044-84e7-dc3c01c8f1ba", "fragment": "#/details/featured_attachments", "message": "The property '#/details/featured_attachments' contained duplicated array values in schema 869a7d30-f94e-5044-84e7-dc3c01c8f1ba", "failed_attribute": "UniqueItems" } ] ```
kevindew
force-pushed
the
allow-unique-arrays
branch
from
March 8, 2021 14:37
1465d89
to
0d42167
Compare
gclssvglx
reviewed
Mar 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great - thanks. Just a quick question...
gclssvglx
approved these changes
Mar 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff - thanks @kevindew
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-calculates the values of an array if the "uniqueItems" property
is set and a non-unique item has been generated. This has been to help
resolve flaky tests that expect a random array and occasionally fail due
to the generation of an array with collisions.
As there is a risk that this can produce an eternal loop I've put in a
check that if there are very number of attempts to generate the unique
value then it should abort. This does produce a risk of failure if there
is a low amount of variance in the allowed variables.
This is to resolve issues such as: