Update the modal component to prevent the page from scrolling behind it when open #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-ju
changed the title
alex-ju
requested review from
aliuk2012 and
andysellick
and removed request for
aliuk2012
alex-ju
force-pushed
the
update-modal-component
branch
from
211bb4f
to
315de3d
Compare
andysellick
reviewed
Mar 28, 2019
app/assets/stylesheets/govuk_publishing_components/components/_modal-dialogue.scss
Show resolved
Hide resolved
app/assets/stylesheets/govuk_publishing_components/components/_modal-dialogue.scss
Show resolved
Hide resolved
app/assets/stylesheets/govuk_publishing_components/components/_modal-dialogue.scss
Show resolved
Hide resolved
alex-ju
force-pushed
the
update-modal-component
branch
from
315de3d
to
b4b2d1b
Compare
govuk-frontend v2.8.0 introduces an overflow-y: scroll for govuk-template that needs to be overwritten when the modal opens otherwise the content will scroll behind the modal. alphagov/govuk-frontend#1230
|
@andysellick are you happy with me to merge this or shall we have a chat about it beforehand? |
|
@alex-ju thanks for asking. I think I'm happy with this change, although I'm still nervous about the non-isolation aspects of the component as a whole. But, this is something we need, so that's fine. |
|
@andysellick I share your worry about isolation. It's the only solution I've seen at the moment to deal with the blur effect. I'm looking into removing it if I find a good alternative that doesn't involve 'communicating' with the template. |
alex-ju
added a commit
to alphagov/content-publisher
that referenced
this pull request
Apr 17, 2019
The modal dialogue component was updated in alphagov/govuk_publishing_components#805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
govuk-frontend v2.8.0 introduces an
overflow-y: scrollfor.govuk-templatethat needs to be overwritten when the modal opens otherwise the content will scroll behind the modal. alphagov/govuk-frontend#1230