Component wrapper documentation fixes #4499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- was missing documentation for a few of the options
- some components use the component wrapper helper but don't have more than one, default example of their appearance in the component guide. A bug meant that in this case the detail of the component wrapper helper wasn't automatically being shown at the top of the list of other examples (because there were no other examples) - correcting and updating the jump link list at the top to also include this as an item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update the component wrapper documentation to include recently added options e.g.
tabindex.Fix a bug with the component guide where the component wrapper options weren't being shown for components that only have one variation (e.g. contextual guidance).
Why
Keeping documentation up to date.
Visual Changes
Changes on the component guide page to the contextual guidance component.
Trello card: https://trello.com/c/ZHmeJbMd/380-fix-missing-component-wrapper-information-on-components-without-variations