Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a description for the metadata block 'see_updates_link' example #4447

Conversation

jon-kirwan
Copy link
Contributor

@jon-kirwan jon-kirwan commented Nov 28, 2024

What

Add a description for the metadata block see_updates_link example

https://components-gem-pr-4447.herokuapp.com/component-guide/metadata/updated_with_links_to_see_details

Why

To provide more information on what these options do, including a link to an example page.

@jon-kirwan jon-kirwan changed the title Add a description for the metadata block see_updates_link example Add a description for the metadata block 'see_updates_link' example Nov 28, 2024
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4447 November 28, 2024 10:24 Inactive
@jon-kirwan jon-kirwan force-pushed the add-a-description-for-the-metadata-block-see-updates-link-example branch from b6af5a7 to 90fb8e6 Compare November 28, 2024 10:25
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4447 November 28, 2024 10:25 Inactive
@jon-kirwan jon-kirwan force-pushed the add-a-description-for-the-metadata-block-see-updates-link-example branch from 90fb8e6 to ee7515b Compare November 28, 2024 10:47
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4447 November 28, 2024 10:48 Inactive
@jon-kirwan jon-kirwan force-pushed the add-a-description-for-the-metadata-block-see-updates-link-example branch from ee7515b to a474a70 Compare November 28, 2024 11:14
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4447 November 28, 2024 11:15 Inactive
@jon-kirwan jon-kirwan marked this pull request as ready for review November 28, 2024 11:16
Copy link
Contributor

@AshGDS AshGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Added a non-blocking comment.

@jon-kirwan jon-kirwan force-pushed the add-a-description-for-the-metadata-block-see-updates-link-example branch from a474a70 to 5400d61 Compare November 28, 2024 12:05
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4447 November 28, 2024 12:05 Inactive
@jon-kirwan jon-kirwan merged commit 34eeb91 into main Nov 28, 2024
12 checks passed
@jon-kirwan jon-kirwan deleted the add-a-description-for-the-metadata-block-see-updates-link-example branch November 28, 2024 12:09
@dnkrj dnkrj mentioned this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants