Allow licence details in footer to be hidden #4438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
reviewed
Nov 26, 2024
app/views/govuk_publishing_components/components/_layout_footer.html.erb
Outdated
Show resolved
Hide resolved
The layout footer component is used quite a lot by internal services, where it doesn’t make sense to show licence details. This adds a `show_licence` option to allow users to hide the licence if they want/need to. This will always default to `true`, unless the option is specifically set to `false`.
pezholio
force-pushed
the
hide-licence-details-in-footer
branch
from
28219e4
to
cba30b7
Compare
andysellick
approved these changes
Nov 26, 2024
|
@pezholio just to check - it looks like this new option hides the licence information, but also all of the links? Is that correct? |
|
Scratch that last comment - it's just that the example doesn't include those links. Ignore me! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layout footer component is used quite a lot by internal services, where it doesn’t make sense to show licence details. This adds a
show_licenceoption to allow users to hide the licence if they want/need to. This will always default totrue, unless the option is specifically set tofalse.