-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update organisation logos #4295
Conversation
385dde3
to
4c053c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a visual standpoint, it all looks good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, I've reviewed it using collections across individual organisation pages and the index one. I've also checked on mobile devices and other supported browsers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Especially after updating the portcullis. 👍🏽
The logos organisation have been updated to reflect the most up-to-date organisation crests. Images that previously had a 52px height have been updated to 64px, the reason for this is that the logo height is set to 32px in the CSS, using 64px as the height will help ensure we serve a 2x image as intended. Images that are 68px in height use a max-height of 34px, so no change in dimensions was made here. Update portcullis_18px_x2.png
786df44
to
555b72b
Compare
What
52px
, now have a height of64px
Why
32px
in the CSS, using64px
as the height will help ensure we serve a 2x image as intended. No change is needed for images that are68px
in height as they have a height of34px
in the CSSTrello card
Visual Changes
Further information
portcullis
crestOther crests not updated as part of this change