Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update organisation logos #4295

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Update organisation logos #4295

merged 3 commits into from
Oct 10, 2024

Conversation

MartinJJones
Copy link
Contributor

@MartinJJones MartinJJones commented Oct 9, 2024

What

  • The logos organisation have been updated to reflect what will be the most up-to-date organisation crests
  • Images that previously had a height of 52px, now have a height of 64px
  • Optimized the images

Why

  • The designs for the organisation logos have been updated
  • The reason for the change in logo height, is that the logo height is set to 32px in the CSS, using 64px as the height will help ensure we serve a 2x image as intended. No change is needed for images that are 68px in height as they have a height of 34px in the CSS
  • Images optimized to help ensure the file size is comparable to the existing organisation logos. Using the organisations page as an example the image size increased from 25.5KB to 52.9KB without any optimization. After optimizing the images the total size of images on the is 27.4KB.

Trello card

Visual Changes

Further information

Before After Comments Live page example
single-identity-before single-identity-after Updates all organisation logos that use the Royal Coat of Arms Cabinet Office
dbt-before dbt-after Crest is also used on UKEF DBT / UKEF
ho-before ho-after Home Office
mod-before mod-after MoD
wales-crest-before wales-crest-after Wales Office
so-before so-after Office of the Advocate General for Scotland / Scotland Office
portcullis-before portcullis-after portcullis crest Office of the Leader of the House of Commons / Office of the Leader of the House of Lords

Other crests not updated as part of this change

Crest Example page
ukho_18px_x2.png UKHO
coastguard_18px_x2.png NA
ukaea_crest_18px_x2.png UKAEA
bis_crest_18px_x2.png BIS

Copy link

@nnagewad nnagewad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a visual standpoint, it all looks good :)

Copy link
Member

@hannalaakso hannalaakso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I've reviewed it using collections across individual organisation pages and the index one. I've also checked on mobile devices and other supported browsers.

Copy link

@nnagewad nnagewad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Especially after updating the portcullis. 👍🏽

The logos organisation have been updated to reflect the most up-to-date organisation crests.

Images that previously had a 52px height have been updated to 64px, the reason for this is that the logo height is set to 32px in the CSS, using 64px as the height will help ensure we serve a 2x image as intended. Images that are 68px in height use a max-height of 34px, so no change in dimensions was made here.

Update portcullis_18px_x2.png
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4295 October 9, 2024 17:41 Inactive
@MartinJJones MartinJJones marked this pull request as ready for review October 10, 2024 14:04
@MartinJJones MartinJJones merged commit a572955 into main Oct 10, 2024
12 checks passed
@MartinJJones MartinJJones deleted the update-org-logos branch October 10, 2024 14:06
@MartinJJones MartinJJones mentioned this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants