Fix homepage super navigation buttons when text scale is increased #4232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
force-pushed
the
menu-fix-text-scale
branch
from
7b6a770 to
91c8b3a
Compare
jon-kirwan
approved these changes
Sep 18, 2024
| @@ -606,6 +608,10 @@ $after-button-padding-left: govuk-spacing(4); | |||
| // Styles for search toggle button. | |||
| .gem-c-layout-super-navigation-header__search-toggle-button { | |||
| background: none; | |||
|
|
|||
| &--blue-background { | |||
There was a problem hiding this comment.
Just a small suggestion - I don't think we have any style guidelines on this, but these types of selectors can be a bit tricky to search for. We could change it to gem-c-layout-super-navigation-header__search-toggle-button--blue-background though I realise that might be a bit verbose so no worries if not.
There was a problem hiding this comment.
Thanks @jon-kirwan - good suggestion, will do this and then merge.
AshGDS
force-pushed
the
menu-fix-text-scale
branch
from
91c8b3a to
243da63
Compare
AshGDS
force-pushed
the
menu-fix-text-scale
branch
from
243da63 to
2e6c00d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
Visual Changes
Before
After
https://trello.com/c/2BSs27tS/35-homepage-visual-issue-when-font-scale-is-increased-on-mobile