Add GA4 redaction to GWF and GB EORI numbers #4227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
force-pushed
the
ga4-redact-visas
branch
from
74da2ea to
e4aeeb3
Compare
andysellick
approved these changes
Sep 17, 2024
| @@ -27,6 +27,10 @@ | |||
| var UNLOCK_TOKEN_PATTERN = /unlock_token=[a-zA-Z0-9-]+/g | |||
| var STATE_PATTERN = /state=.[^&]+/g | |||
|
|
|||
| // some users mistakenly use GOV.UK to search for the status of their applications. | |||
There was a problem hiding this comment.
Suggestion: might help to add to this comment an example of the numbers this should match.
There was a problem hiding this comment.
Although I've just noticed there's some in the spec file, so 🤷
There was a problem hiding this comment.
No worries, will add more specific examples then merge 👍
AshGDS
force-pushed
the
ga4-redact-visas
branch
from
e4aeeb3 to
69f9da3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Visual Changes
None.