Stop redacting dates in GA4 tracking on GOVUK search pages #4223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
force-pushed
the
ga4-search-date-redaction
branch
from
d83e414 to
7d808b4
Compare
AshGDS
force-pushed
the
ga4-search-date-redaction
branch
from
7d808b4 to
1d4af5b
Compare
AshGDS
force-pushed
the
ga4-search-date-redaction
branch
from
1d4af5b to
a40c8a6
Compare
AshGDS
force-pushed
the
ga4-search-date-redaction
branch
from
a40c8a6 to
5da9980
Compare
AshGDS
force-pushed
the
ga4-search-date-redaction
branch
from
5da9980 to
20528f7
Compare
andysellick
approved these changes
Sep 17, 2024
| @@ -78,7 +78,9 @@ window.GOVUK.analyticsGa4.analyticsModules = window.GOVUK.analyticsGa4.analytics | |||
| }, | |||
|
|
|||
| getLocation: function () { | |||
| return this.PIIRemover.stripPIIWithOverride(this.stripGaParam(document.location.href), true, true) | |||
| // We don't want to remove dates on search pages. | |||
| var stripDates = !this.getSearchTerm() | |||
There was a problem hiding this comment.
This line gets repeated later - would it be possible to store this value on initialisation?
There was a problem hiding this comment.
Thanks @andysellick - good point, i've changed it so that it's only called once. Are you able to re-review?
AshGDS
force-pushed
the
ga4-search-date-redaction
branch
from
20528f7 to
5975578
Compare
andysellick
approved these changes
Sep 17, 2024
Merged
csutter
added a commit
to alphagov/finder-frontend
that referenced
this pull request
Sep 23, 2024
A recent change in `govuk_publishing_components` removed date redaction from search term updates: alphagov/govuk_publishing_components#4223 The GA4 finder tracking spec additionally tests this behaviour, so was failing when the gem was bumped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
standardiseSearchTermfunction, - this function ensures the search term tracks the same across multiple parameters, so dates should no longer be redacted wherever we grab a search term.location,query_string, andsearch_termvalues in the PageView tracker.Visual Changes
None.