Update metatags for GA4 #4222
Merged
Update metatags for GA4 #4222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove the `analytics:` part from world-locations and organisations meta tags, to make them more consistent with the other meta tags
AshGDS
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Looks good, but just wanted to check - if things like strip-dates are no longer tagged with an analytics name, does that go against what we've been doing in other places?
For example, in meta_tags.rb we have some GA4 specific tags that are:
meta_tags["govuk:ga4-political-status"] = "historic"
meta_tags["govuk:ga4-publishing-government"]
and code wise, we name spaced everything with ga4-, so should the PII specific tags have ga4- on them?
Non-blocking though, so feel free to merge.
andysellick
force-pushed
the
ga4-metatags
branch
from
a318a81 to
9e44162
Compare
|
Good point @AshGDS, thanks, have updated as suggested. |
- not needed, and confusing, as analytics now has little to do with static
- comment is out of date as refers to old Universal Analytics code that has been removed - on that basis tested to see if removing the line it refers to is still necessary, tests still pass, so removed
- more descriptive and accurate to what it contains
andysellick
force-pushed
the
ga4-metatags
branch
from
9e44162 to
5cea184
Compare
Merged
andysellick
added a commit
that referenced
this pull request
Sep 18, 2024
- recently updated the names of some of the metatags that GA4 reads for page views - but it's possible that the changes to those metatags won't be appearing for a while on a lot of pages, as they probably need republishing first - so for now let's read either the new or the old metatag (which will contain the same information) and avoid breaking a part of the GA4 tracking - haven't done the same for the strip dates/postcodes/etc. metatags as I think they're all handled internal to the gem - follow up to changes made in #4222
andysellick
added a commit
that referenced
this pull request
Sep 18, 2024
- recently updated the names of some of the metatags that GA4 reads for page views - but it's possible that the changes to those metatags won't be appearing for a while on a lot of pages, as they probably need republishing first - so for now let's read either the new or the old metatag (which will contain the same information) and avoid breaking a part of the GA4 tracking - haven't done the same for the strip dates/postcodes/etc. metatags as I think they're all handled internal to the gem - follow up to changes made in #4222
andysellick
added a commit
that referenced
this pull request
Sep 18, 2024
- recently updated the names of some of the metatags that GA4 reads for page views - but it's possible that the changes to those metatags won't be appearing for a while on a lot of pages, as they probably need republishing first - so for now let's read either the new or the old metatag (which will contain the same information) and avoid breaking a part of the GA4 tracking - haven't done the same for the strip dates/postcodes/etc. metatags as I think they're all handled internal to the gem - follow up to changes made in #4222
andysellick
added a commit
that referenced
this pull request
Sep 18, 2024
- recently updated the names of some of the metatags that GA4 reads for page views - but it's possible that the changes to those metatags won't be appearing for a while on a lot of pages, as they probably need republishing first - so for now let's read either the new or the old metatag (which will contain the same information) and avoid breaking a part of the GA4 tracking - haven't done the same for the strip dates/postcodes/etc. metatags as I think they're all handled internal to the gem - follow up to changes made in #4222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates GOV.UK page metatags used by GA4 to make them more consistent. See individual commits for details.
Must be deployed with alphagov/slimmer#341
Why
This is some final tidying up post GA4 launch, to make things more consistent and clear.
Visual Changes
None.
Trello card: https://trello.com/c/lIVmnFpY/336-page-view-enhancement-some-meta-tags-start-with-analytics