Add govuk-frontend checking to the component auditing #4058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- now checks components for the presence of govuk-frontend JS and CSS imports
- reorder the columns on the component contents section to be more logical - add title text to the table headers and table contents to clarify their meaning - add explanation at the top of the table
andysellick
force-pushed
the
auditing-govukfrontend
branch
from
106d4af to
bcf555e
Compare
|
Looks good to me, think the version number may need to be updated in the change log though |
andysellick
force-pushed
the
auditing-govukfrontend
branch
from
bcf555e to
b54458d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Expand the component auditing to check components for the presence of
govuk-frontendJS and CSS imports i.e. to show which components directly use assets fromgovuk-frontend.Why
This was a feature previously raised by @patrickpatrickpatrick in #3716 as something that would be useful as we move to using
govuk-frontendv5 and the ES6 code additions that this includes. I've changed where the information is shown and expanded to include both JS and CSS.Visual Changes
Now includes the two 'GF' columns.