Fix rendering of unnumbered papers #3988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
approved these changes
Apr 19, 2024
|
@andysellick Thanks for reviewing. Will squash the commits.
Yeah, the new one hasn't been released yet. |
The "false" check in the unnumbered command and act papers was failing because the component is passed an empty string rather than nil for the number, which does not evaluate to false: e.g. a = false !a => true b = nil !b => true c = "" !c => false Therefore the check was returning `nil` rather than the "Unnumbered..." text.
leenagupte
force-pushed
the
fix-unnumbered-paper-rendering
branch
from
293d44c to
55ae60d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix rendering of unnumbered papers so that "Unnumbered..." is displayed
Why
The "false" check in the unnumbered command and act papers was failing because the component is passed an empty string rather than nil for the number, which does not evaluate to false:
e.g.
Therefore the check was returning
nilrather than the "Unnumbered..." text.Visual Changes
Before
After