Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PDF specific icon to attachment component #3985

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

andysellick
Copy link
Contributor

What / why

  • adds a specific icon for PDFs to the attachment component
  • this change to distinguish PDFs in a standard way from other attachment types, now that custom preview icons for PDFs are being removed

Visual Changes

Will impact pages such as https://www.gov.uk/government/publications/make-a-lasting-power-of-attorney

Before After
Screenshot 2024-04-19 at 10 58 36 Screenshot 2024-04-19 at 10 58 42

Trello card: https://trello.com/c/tcTN1jbu/28-update-rendering-of-govspeak-attachments

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3985 April 19, 2024 10:00 Inactive
- adds a specific icon for PDFs to the attachment component
- this change to distinguish PDFs in a standard way from other attachment types, now that custom preview icons for PDFs are being removed
@andysellick andysellick force-pushed the attachment-pdf-icon branch from 904de94 to 48cc5f6 Compare April 19, 2024 10:32
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3985 April 19, 2024 10:32 Inactive
@andysellick andysellick requested a review from AshGDS April 19, 2024 10:33
Copy link
Contributor

@AshGDS AshGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@andysellick andysellick merged commit 7c2c850 into main Apr 19, 2024
13 checks passed
@andysellick andysellick deleted the attachment-pdf-icon branch April 19, 2024 10:57
@matthillco matthillco mentioned this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants