Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tool_name to GA4 feedback component tracking #3984

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Add tool_name to GA4 feedback component tracking #3984

merged 2 commits into from
Apr 19, 2024

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Apr 18, 2024

What

  • Adds tool_name to the GA4 feedback component tracking
  • Adds tests to the component - for context this tracking was added early on in the GA4 project, so I don't think we had our spec test process set up at that time.

Why

Visual Changes

None.

@AshGDS AshGDS changed the title Ga4 feedback tool name Add tool_name to GA4 feedback component tracking Apr 18, 2024
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3984 April 18, 2024 11:31 Inactive
@AshGDS AshGDS force-pushed the ga4-feedback-tool-name branch from 97ca1c3 to 5cbadd3 Compare April 18, 2024 11:32
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3984 April 18, 2024 11:32 Inactive
@AshGDS AshGDS force-pushed the ga4-feedback-tool-name branch from 5cbadd3 to 6fa7134 Compare April 18, 2024 11:33
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3984 April 18, 2024 11:34 Inactive
@AshGDS AshGDS requested a review from andysellick April 18, 2024 11:40
andysellick
andysellick approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@AshGDS AshGDS merged commit a2eaf8b into main Apr 19, 2024
13 checks passed
@AshGDS AshGDS deleted the ga4-feedback-tool-name branch April 19, 2024 08:54
@matthillco matthillco mentioned this pull request Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andysellick andysellick andysellick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AshGDS @andysellick @govuk-ci