Font changes ahead of apps being made compatible with govuk-frontend v5 #3981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthillco just glanced through the Percy visual diff and this all looks fine to me - I don't think there should be any blockers to getting this deployed. |
|
@matthillco organisation logo changes also look good to me - actually much improved on mobile, far more readable. Is there anything else to add to this PR or is it ready for review? |
I'm prepping another update to logos for Rebecca to review in the spike branch, once she's approved that, I can copy those changes to this branch. |
matthillco
force-pushed
the
font-changes
branch
from
6ee968c to
4f07362
Compare
andysellick
reviewed
Apr 22, 2024
app/assets/stylesheets/govuk_publishing_components/components/_organisation-logo.scss
Show resolved
Hide resolved
andysellick
reviewed
Apr 22, 2024
app/assets/stylesheets/govuk_publishing_components/components/_search.scss
Outdated
Show resolved
Hide resolved
matthillco
force-pushed
the
font-changes
branch
from
4f07362 to
8ed78ca
Compare
matthillco
force-pushed
the
font-changes
branch
from
8ed78ca to
1b7f17f
Compare
matthillco
changed the title
The original treatment for logos used multiple sizes and screen density media queries to send low/high resolution images depending on the screen density. By increasing the size of the logos, the low resolution images are now too small so support for those has been dropped and we now use only the larger sizes. These larger images are scaled down by the browser and so will look sharper enough on low density screens. The mixin for the crest was also changed to allow the passing of different offsets, as some logos now need small adjustments to optically match the alignment with the text.
matthillco
force-pushed
the
font-changes
branch
from
39ad756 to
747afd6
Compare
andysellick
reviewed
Apr 22, 2024
matthillco
force-pushed
the
font-changes
branch
from
747afd6 to
4905819
Compare
andysellick
approved these changes
Apr 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Font size changes for upcoming
govuk-frontendchanges in v5 upgrade.https://trello.com/c/o9rgYI3C/21-implement-font-changes
Why
Test out the font size changes ahead of the release.
Visual Changes
14px fonts have been changed to 16px in these elements: