Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auditing filename bug #3754

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Fix auditing filename bug #3754

merged 1 commit into from
Dec 7, 2023

Conversation

andysellick
Copy link
Contributor

What / why

  • in the 'gem components used by applications' section of the component auditing, some of the links appeared incomplete or duplicate
  • this is because those files started with or contained a number, and the regex that converted the full file path into a relative link and github link wasn't including numbers, so the output was incorrect
  • amending regex to include numbers seems to have solved the problem

Fixes #3713

Visual Changes

Before After
Screenshot 2023-12-06 at 15 44 11 Screenshot 2023-12-06 at 15 44 42

- in the gem components used by applications section of the component auditing, some of the links appeared incomplete or duplicate
- this is because those files started with or contained a number, and the regex that converted the full file path into a relative link and github link wasn't including numbers, so the output was incorrect
- amending regex to include numbers seems to have solved the problem
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3754 December 6, 2023 15:46 Inactive
@andysellick andysellick merged commit 1ec5ec0 into main Dec 7, 2023
10 checks passed
@andysellick andysellick deleted the fix-audit-number-bug branch December 7, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component auditing fails to understand templates starting with numbers
3 participants