Add GA4 tracking for content navigation #3420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
reviewed
Jun 5, 2023
app/views/govuk_publishing_components/components/_contents_list.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_contents_list.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_previous_and_next_navigation.html.erb
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_previous_and_next_navigation.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_previous_and_next_navigation.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_previous_and_next_navigation.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_previous_and_next_navigation.html.erb
Show resolved
Hide resolved
|
Thanks @andysellick I've made the changes - will squash everything once approved 👍 |
andysellick
approved these changes
Jun 6, 2023
| local_assigns[:aria] ||= {} | ||
| component_helper = GovukPublishingComponents::Presenters::ComponentWrapperHelper.new(local_assigns) | ||
| component_helper.add_class("gem-c-contents-list #{brand_helper.brand_class}") | ||
| component_helper.add_data_attribute({ module: "gem-track-click" }) | ||
| component_helper.add_data_attribute({ module: "ga4-link-tracker" }) if ga4_tracking | ||
| component_helper.add_data_attribute({ga4_link: ga4_data, ga4_track_links_only: ""}) if ga4_tracking |
There was a problem hiding this comment.
Nitpick: can you add spaces to match the previous lines? i.e.
component_helper.add_data_attribute({ ga4_link: ga4_data, ga4_track_links_only: "" }) if ga4_tracking
| ga4_link_data = nil | ||
| if ga4_tracking | ||
| ga4_link_data = {"index": {"index_link": position}, "index_total": contents.length}.to_json | ||
| end |
There was a problem hiding this comment.
Should be able to shorten this? Also (nitpick) please add spaces to improve readability, as shown.
ga4_link_data = { "index": { "index_link": position }, "index_total": contents.length }.to_json if ga4_tracking
I didn't use data-ga4-set-indexes as the page you're on is part of the list, but it isn't a link. So it needs to be included in the indexes, but it's not a HTML link. data-ga4-set-indexes only sets indexes by presence of HTML links. Therefore the index_total and indexes would always be off. Therefore we manually set the indexes in the template so that the item that isn't a link in the list is included.
AshGDS
force-pushed
the
ga4-content-navigation
branch
from
200397b to
9c8a584
Compare
|
Thanks @andysellick, squashed and fixed those two issues. Would you be able to approve the Percy change? Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would you be able to approve this PR if all is OK? Thanks 👍
What
Adds the
ga4_trackingoption to three components. When this is set to true, it will add the relevant GA4 attributes.Why
https://trello.com/c/C9M2EJQu/553-content-navigation-chapter-headings-next-previous-view-a-printable-version-navigation-and-show-hide-updates-interaction
I have a branch in
government-frontendthat will use these attributes.Visual Changes
None.