Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor ecommerce tracking refactor #3098

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Conversation

JamesCGDS
Copy link
Contributor

What

This PR refactors ecommerce tracking to use the sendData() function in ga4-core.js when pushing to the dataLayer (as opposed to calling window.dataLayer.push() directly).

Why

To maintain consistency in how we push data to the dataLayer.

Visual Changes

N/A

Refactored to use the sendData core function when pushing to the dataLayer
@JamesCGDS JamesCGDS requested a review from AshGDS December 1, 2022 14:26
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3098 December 1, 2022 14:26 Inactive
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3098 December 1, 2022 14:28 Inactive
@JamesCGDS JamesCGDS merged commit 0a89ddd into main Dec 1, 2022
@JamesCGDS JamesCGDS deleted the ga4_refactor_ecommerce_tracking branch December 1, 2022 14:35
@AshGDS AshGDS mentioned this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants