Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share links allow data attributes #3072

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Share links allow data attributes #3072

merged 1 commit into from
Nov 17, 2022

Conversation

andysellick
Copy link
Contributor

What

Extend the share links component to allow optional data attributes to be passed to the parent and the individual links.

Note that the component already includes a data-module of gem-track-click by default, this is preserved now even if another value for module is passed.

Why

We want to track this component in the new GA4 world and passing attributes like this is our approach.

Visual Changes

No visual changes.

Screenshot 2022-11-17 at 10 43 18

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3072 November 17, 2022 10:45 Inactive
- allow the share links component to accept data attributes for both the parent and the individual links
@andysellick andysellick force-pushed the share-links-attributes branch from d5c072b to 3cae90a Compare November 17, 2022 10:47
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3072 November 17, 2022 10:47 Inactive
@andysellick andysellick merged commit 15ed4f8 into main Nov 17, 2022
@andysellick andysellick deleted the share-links-attributes branch November 17, 2022 11:38
@andysellick andysellick mentioned this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants