Remove target from mailto: link #3023
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-kirwan
changed the title
mailto: link
jon-kirwan
force-pushed
the
email-links-for-attachments-open-in-a-new-window
branch
from
9792278 to
7004c21
Compare
jon-kirwan
force-pushed
the
email-links-for-attachments-open-in-a-new-window
branch
from
7004c21 to
c4ee7f9
Compare
jon-kirwan
force-pushed
the
email-links-for-attachments-open-in-a-new-window
branch
from
c4ee7f9 to
8ed9d26
Compare
jon-kirwan
force-pushed
the
email-links-for-attachments-open-in-a-new-window
branch
from
8ed9d26 to
9e3c690
Compare
jon-kirwan
changed the title
mailto: link
maxgds
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
Happy to approve this as an improvement but I'm not entirely sure it solves the issue. I'm not clear on what the interaction will be for the user when a new application is launched but I suspect it might be good to indicate that this is going to happen. I feel this needs research though, mailto links are a bit questionable generally.
jon-kirwan
force-pushed
the
email-links-for-attachments-open-in-a-new-window
branch
from
9e3c690 to
fd97b45
Compare
jon-kirwan
force-pushed
the
email-links-for-attachments-open-in-a-new-window
branch
from
fd97b45 to
11600ea
Compare
|
I'm closing this pull request pending further discussion to decide on best practice for this issue. Options to explore include:
See find and view: |
jon-kirwan
deleted the
email-links-for-attachments-open-in-a-new-window
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove
targetfrommailto:link in attachment component.https://trello.com/c/NF2f49BS/1575-email-links-for-attachments-dont-point-out-they-open-in-a-new-window
Why
When an attachment has an email address for contacting about an accessible format, the email link opens in a new window without informing the user. This can be disorientating for screen reader users who may not know that a window has opened.
Example URL: