Fix bug when getting target element from URL hash #2985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinJJones
force-pushed
the
fix-accordion-bug
branch
from
d6c7de8 to
3637afc
Compare
MartinJJones
changed the title
MartinJJones
force-pushed
the
fix-accordion-bug
branch
from
3637afc to
e6c3000
Compare
MartinJJones
force-pushed
the
fix-accordion-bug
branch
from
e6c3000 to
ccddca5
Compare
jon-kirwan
approved these changes
Sep 26, 2022
app/assets/javascripts/govuk_publishing_components/components/accordion.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/govuk_publishing_components/components/accordion.js
Outdated
Show resolved
Hide resolved
MartinJJones
force-pushed
the
fix-accordion-bug
branch
from
ccddca5 to
940900f
Compare
When searching for the target element we now restrict this to the accordion component, instead of the searching the entire document. The html fixture was also updated in the related test to add a closing div tag that was missing.
MartinJJones
force-pushed
the
fix-accordion-bug
branch
from
940900f to
98bce4b
Compare
|
Amended note in the Changelog |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update the accordion component to only look for a target element within the module itself, not the entire document.
Why
This fixes a bug when
anchor_navigationis set totrueand an ID is passed in for an element that exists on the page, but is not contained within the accordion component.For example: https://www.gov.uk/guidance/how-to-publish-on-gov-uk/creating-and-updating-pages#section-title
Further Info
Fixes: #2086
Trello: https://trello.com/c/q5P6u7id/1507-ps-17-accordion-anchor-link-navigation-breaks-with-invalid-anchor
Using querySelector when the ID contains a colon
There was also a need to escape the colon character when using
querySelector, for example$this.module.querySelector('#fnref:1')would throw an error 1Footnotes
Bugzilla - querySelector doesn't work if the ID contains a colon (:) ↩