Use section for emergency banner #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickpatrickpatrick
force-pushed
the
update-emergency-banner
branch
from
7cd11f3 to
d720939
Compare
patrickpatrickpatrick
force-pushed
the
update-emergency-banner
branch
from
d720939 to
1d5aa2a
Compare
hannalaakso
approved these changes
Sep 26, 2022
hannalaakso
requested changes
Sep 26, 2022
patrickpatrickpatrick
force-pushed
the
update-emergency-banner
branch
from
1d5aa2a to
6c0b0c6
Compare
|
have added that test |
When the emergency banner was deployed on GOV.UK, some changes were made based on the feedback from an accessibility specialist. These changes involved removing the role attribute from the parent div and changing the element of the parent div to a section. This is to avoid any accidental duplication of roles on any page of GOV.UK. In accordance with this change, the aria-label has been changed to aria-labelledby instead. Have also added a test to make sure the label is being applied correctly. Co-authored-by: Max Froumentin <[email protected]>
patrickpatrickpatrick
force-pushed
the
update-emergency-banner
branch
from
6c0b0c6 to
a0eee16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Small adjustments to the template of emergency banner for accessibility reasons.
Why
When the emergency banner was deployed on GOV.UK, some changes were made based on the feedback from an accessibility specialist. These changes involved removing the role attribute from the parent div and changing the element of the parent div to a section. This is to avoid any accidental duplication of roles on any page of GOV.UK. In accordance with this change, the aria-label has been changed to aria-labelledby instead.
Co-author with @maxf who made the changes to static (which will be removed when the emergency banner static PR has been merged).