Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a large image for the large example #2875

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Use a large image for the large example #2875

merged 1 commit into from
Jul 25, 2022

Conversation

andysellick
Copy link
Contributor

What / why

  • the image used for the large image card configuration example wasn't large, so didn't clearly show what the intent of the option was
  • adding a large image to make better use of the space

Visual Changes

Before After
Screenshot 2022-07-25 at 14 49 59 Screenshot 2022-07-25 at 14 50 05

@andysellick
Use a large image for the large example
bde887e 
- the image used for the large image card configuration example wasn't large, so didn't clearly show what the intent of the option was
- adding a large image to make better use of the space
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-2875 July 25, 2022 13:51 Inactive
@jon-kirwan jon-kirwan self-requested a review July 25, 2022 13:56
@andysellick andysellick merged commit 07fa737 into main Jul 25, 2022
@andysellick andysellick deleted the update-image-card-large-example branch July 25, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jon-kirwan jon-kirwan jon-kirwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andysellick @jon-kirwan @govuk-ci