Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase big number label size #2506

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Increase big number label size #2506

merged 1 commit into from
Dec 9, 2021

Conversation

owenatgov
Copy link
Contributor

What

Reinstates the use of govuk-font for big number labels so that it is 19px on desktop and 16px on mobile (change managed by the font mixin).

Why

Recommendations by our designer as part of the new homepage work. The larger label will generally make it more legible on desktop.

Card

Visual Changes

Before

Screenshot 2021-12-09 at 11 29 21

After

Screenshot 2021-12-09 at 11 29 28

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-2506 December 9, 2021 11:30 Inactive
@owenatgov owenatgov force-pushed the big-number-label-size branch from 1b0e5df to 633df3d Compare December 9, 2021 11:31
@owenatgov owenatgov marked this pull request as ready for review December 9, 2021 11:31
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-2506 December 9, 2021 11:31 Inactive
@owenatgov owenatgov force-pushed the big-number-label-size branch from 633df3d to 2092f99 Compare December 9, 2021 11:36
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-2506 December 9, 2021 11:36 Inactive
Copy link
Contributor

@jon-kirwan jon-kirwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@owenatgov owenatgov force-pushed the big-number-label-size branch from 2092f99 to a1dae14 Compare December 9, 2021 12:02
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-2506 December 9, 2021 12:03 Inactive
@mia-allers-gds
Copy link

Looks good @owenatgov !

@owenatgov owenatgov merged commit f36d93a into master Dec 9, 2021
@owenatgov owenatgov deleted the big-number-label-size branch December 9, 2021 12:19
@danacotoran danacotoran mentioned this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants