Fix inconsistent navigation header hover states #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hover colour didn't have the required contrast when on smaller screens, so has been changed to the same hover colour as standard links.
The borders on the toggle buttons were disappearing depending on the state that they were in. This has been fixed, but will probably need a refactor in the future so it makes a bit more sense.
chao-xian
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates the borders and hover states of the navigation header buttons and links.
Why
The hover states and borders of the navigation header links and toggle buttons were inconsistent.
Visual Changes
Mobile view link hover state
Search button hover state
Before:
After:
