Revert "Fix cookie banner issue (IE10)" #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injms
reviewed
Aug 12, 2021
CHANGELOG.md
Outdated
| @@ -15,7 +15,6 @@ | |||
| # 25.3.0 | |||
|
|
|||
| * Extend track click script ([PR #2263](https://github.com/alphagov/govuk_publishing_components/pull/2263)) | |||
| * Fix cookie banner issue (IE10) ([PR #2231](https://github.com/alphagov/govuk_publishing_components/pull/2231)) | |||
There was a problem hiding this comment.
I think that this should be kept in, and then a revert "Fix cookie banner..." item added as well since v25.3.0 of the gem will still have this in it.
This reverts commit b17d981.
danacotoran
force-pushed
the
revert-cookie-banner-ie10-fix
branch
from
dc4af9f to
859d2a4
Compare
injms
approved these changes
Aug 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b17d981.