Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language tag for Welsh link in public layout template #2258

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

jon-kirwan
Copy link
Contributor

What

Add language tag for Welsh link in public layout template -

<li class="govuk-footer__inline-list-item">
  <a class="govuk-footer__link" lang="cy" href="/cymraeg">Rhestr o Wasanaethau Cymraeg</a>
</li>

Why

Fail of WCAG SC 3.1.2

@bevanloon bevanloon temporarily deployed to govuk-publis-fix-langua-rldanm August 10, 2021 14:35 Inactive
@jon-kirwan jon-kirwan requested a review from maxgds August 11, 2021 08:59
@danacotoran
Copy link
Contributor

@jon-kirwan thanks for this addition; unfortunate that we missed this to begin with!
Happy to approve the PR once you've added an entry to CHANGELOG.md?

@jon-kirwan jon-kirwan force-pushed the fix-language-tag-in-the-public-layout-template branch from 016a5d5 to 714a331 Compare August 12, 2021 09:09
@bevanloon bevanloon had a problem deploying to govuk-publis-fix-langua-rldanm August 12, 2021 09:10 Failure
@jon-kirwan
Copy link
Contributor Author

Thanks for the review @danacotoran 👍 That's now been amended.

@bevanloon bevanloon temporarily deployed to govuk-publis-fix-langua-rldanm August 12, 2021 10:15 Inactive
@jon-kirwan jon-kirwan force-pushed the fix-language-tag-in-the-public-layout-template branch from 5219102 to 0f4e7cb Compare August 12, 2021 10:18
@bevanloon bevanloon temporarily deployed to govuk-publis-fix-langua-rldanm August 12, 2021 10:18 Inactive
@jon-kirwan jon-kirwan force-pushed the fix-language-tag-in-the-public-layout-template branch from 0f4e7cb to f15474f Compare August 12, 2021 11:00
@bevanloon bevanloon temporarily deployed to govuk-publis-fix-langua-rldanm August 12, 2021 11:01 Inactive
@jon-kirwan jon-kirwan merged commit 41bd820 into master Aug 12, 2021
@jon-kirwan jon-kirwan deleted the fix-language-tag-in-the-public-layout-template branch August 12, 2021 11:34
@andysellick andysellick mentioned this pull request Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants