Add real user metrics using Speedcurve's LUX #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add test to ensure both scripts are present in the public layout component only when a user has allowed usage tracking cookies - Adds `lux` and `lux-polyfill` to the assets precompile list - Updates the LUX script to ensure that the image beacon is used - Updates the LUX script to add GDS's Speedcurve user ID number - usually this is appended to the script `src` with a query string, but that doesn't work in this instance as Rails adds a fingerprint to the filename that prevents the script from finding itself - Prettifies `lux-polyfill` to make it slightly easier to see what's going on; this is compressed when going through the asset pipeline - Add documentation explaining RUM and how to update the LUX scripts
injms
force-pushed
the
add-rum-to-public-layout
branch
from
44fbf33 to
51fd6a2
Compare
andysellick
reviewed
Jun 15, 2021
app/assets/javascripts/govuk_publishing_components/vendor/lux/lux-polyfill.js
Show resolved
Hide resolved
| // Setting debug to `true` shows what happening as it happens. Running | ||
| // `LUX.getDebug()` in the browser's console will show the history of what's | ||
| // happened. | ||
| LUX.debug = false; |
There was a problem hiding this comment.
This adds quite a lot of JS. Do we know exactly what the file size impact of this change will be?
There was a problem hiding this comment.
So the file sizes are:
| File | rum-loader |
lux-polyfill |
lux |
|---|---|---|---|
| Uncompressed | 1.5kb | 3.5kb | 33.5kb |
| Minified | 1.1kb | 2.3kb | 21.8kb |
| Minified and compressed | 0.4kb | 0.7kb | 6.6kb |
So the total sent over the wire is 7.8kb.
All of which is loaded using the async attribute - so it won't block any loading or rendering of the page.
There was a problem hiding this comment.
Good numbers, and good to see you've got the stats. Worth adding to the docs?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds the real user metrics to the public layout component by adding the LUX scripts. This includes:
luxandlux-polyfillto the assets precompile listsrcwith a query string, but that doesn't work in this instance as Rails adds a fingerprint to the filename that prevents the script from finding itselflux-polyfillto make it slightly easier to see what's going on; this is compressed when going through the asset pipelineWhy
Real user metrics will give a much greater insight into the performance of GOV.UK for everyone. This will show in greater detail what parts of GOV.UK can be improved without using synthetic tests and what steps can be taken to improve the experience for everyone.
This is a sibling pull request to alphagov/static#2445 - that covers the
core_layouttemplate; this pull request ensures that thegem_layoutin static has feature parity.Visual Changes
None.