Add default aria label for navigation items #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenatgov
force-pushed
the
default-aria-label-for-navigation-items
branch
from
ad4ef48 to
f9dd6da
Compare
chris-gds
reviewed
Feb 24, 2021
app/views/govuk_publishing_components/components/layout_header/_navigation_items.html.erb
Show resolved
Hide resolved
andysellick
reviewed
Feb 24, 2021
| @@ -1,3 +1,5 @@ | |||
| <% navigation_aria_label ||= "Top level" %> | |||
There was a problem hiding this comment.
I'm obviously late to this party, but it would be great if this text could be pulled from the translations file.
Merged
This was referenced Mar 11, 2021
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a default value for
navigation_aria_labelto thenavigation_itemssub-component.Why
Currently,
navigation_aria_labelis passed directly tonavigation_itemswithout any defaulting under the assumption that it's only used bylayout_header. This however breaks anything that's only using the separately exposed navigation_items. Adding a default here allows the sub-component to render without needed to pass a custom aria label if it isn't required.No visual changes.