Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v23.0.0 #1744

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Release v23.0.0 #1744

merged 1 commit into from
Oct 26, 2020

Conversation

injms
Copy link
Contributor

@injms injms commented Oct 21, 2020 •
edited by andysellick
Loading

Note - this is version 23.0.0 due to a previously yanked version using v22.0.0; this release is unrelated to the yanked version.

  • Add track click code from static (PR #1751)
  • Fix active state on action link (PR #1749)
  • Add heading option to input component (PR #1747) MINOR
  • Add analytics from static (PR #1745) MINOR
  • BREAKING Layout header component always displays product name and environment when provided (PR #1736)
  • Add heading option to panel component (PR #1741) MINOR
  • BREAKING Force contents list title to always be Contents or regional equivalent (PR #1734)
  • BREAKING Remove ability to pass Govspeak unsanitized HTML (PR #1632)

@bevanloon bevanloon temporarily deployed to govuk-publis-v23-0-0-07jtufhgg October 21, 2020 19:08 Inactive
andysellick
andysellick approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth updating the PR description to explain why this is release 23 and not 22.

@bevanloon bevanloon temporarily deployed to govuk-publis-v23-0-0-07jtufhgg October 21, 2020 19:14 Inactive
@bevanloon bevanloon temporarily deployed to govuk-publis-v23-0-0-07jtufhgg October 23, 2020 19:05 Inactive
@andysellick
Copy link
Contributor

@injms I've rebased this and updated the description following the merge of the analytics and input label as heading PRs.

@andysellick
Copy link
Contributor

Also would be good to get #1751 into this release as well, if possible.

@injms @andysellick
Release v23.0.0
9d6a644 
* **BREAKING** Layout header component always displays product name and environment when provided ([PR #1736](#1736))
* Add heading option to panel component ([PR #1741](#1741)) MINOR
* **BREAKING** Force contents list title to always be Contents or regional equivalent ([PR #1734](#1734))
* **BREAKING** Remove ability to pass Govspeak unsanitized HTML ([PR #1632](#1632))
@bevanloon bevanloon temporarily deployed to govuk-publis-v23-0-0-07jtufhgg October 26, 2020 16:25 Inactive
@andysellick
Copy link
Contributor

Have rebased to include #1751

@alex-ju alex-ju marked this pull request as ready for review October 26, 2020 17:12
@alex-ju alex-ju merged commit e6be56d into master Oct 26, 2020
@alex-ju alex-ju deleted the v23.0.0 branch October 26, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andysellick andysellick andysellick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@injms @andysellick @bevanloon @alex-ju