Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jQuery from select.js #1670

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Remove jQuery from select.js #1670

merged 1 commit into from
Sep 24, 2020

Conversation

andysellick
Copy link
Contributor

What

Remove jQuery from select.js

  • select.js is used to trigger analytics events on select elements
  • it seems to be only used by finder-frontend
  • it has an option for extra options to be added to the tracking via a data attribute on the select option elements
  • this option does not appear to be in use by finder-frontend, and there was no test for it, so I've added one

Why

To reduce our dependency on jQuery.

Visual Changes

None.

@bevanloon bevanloon temporarily deployed to govuk-publis-remove-jqu-oomu8g September 4, 2020 11:11 Inactive
@andysellick andysellick requested a review from alex-ju September 4, 2020 11:11
@andysellick andysellick force-pushed the remove-jquery-from-select-js branch from 219030e to 556f730 Compare September 4, 2020 11:12
@bevanloon bevanloon temporarily deployed to govuk-publis-remove-jqu-oomu8g September 4, 2020 11:13 Inactive
@andysellick andysellick requested a review from injms September 8, 2020 09:10
@andysellick andysellick force-pushed the remove-jquery-from-select-js branch 2 times, most recently from b3d98f4 to dc721a1 Compare September 22, 2020 14:45
alex-ju
alex-ju approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@alex-ju alex-ju left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, Andy! Reviewed the code and had a play with it. May need a rebase for the changelog. Apologies for the delay on it.

@andysellick
Remove jQuery from select.js
b4ee530 
- select.js is used to trigger analytics events on select elements
- it seems to be only used by finder-frontend
- it has an option for extra options to be added to the tracking via a data attribute on the select option elements
- this option does not appear to be in use by finder-frontend, and there was no test for it, so I've added one
@andysellick andysellick force-pushed the remove-jquery-from-select-js branch from dc721a1 to b4ee530 Compare September 24, 2020 15:52
@andysellick andysellick merged commit b9df890 into master Sep 24, 2020
@andysellick andysellick deleted the remove-jquery-from-select-js branch September 24, 2020 15:57
@owenatgov owenatgov mentioned this pull request Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-ju alex-ju alex-ju approved these changes

@injms injms Awaiting requested review from injms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andysellick @alex-ju @bevanloon