Add h2 tag into legend by default #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a h2 tag inside the legend tag within the radio component.
Why
This was raised during the accessibility audit of govuk. On the cookie page, all the headings are legends. As well as this being confusing to users because these look like headings, it mens that this page can't be navigated through using the headings. This solution of putting headings within the legends is the solution used by the design system for radio buttons. This solution has been backed up by Anika and the content community.
No intended visual changes.
Card: https://trello.com/c/mCncj7BE/328-cookies-page-missing-headings