-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow requests for all domains e.g. <app>.dev.gov.uk #1628
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevindew
reviewed
Jul 27, 2020
alex-ju
force-pushed
the
allow-requests-from-all-domains
branch
from
July 27, 2020 15:47
ed2af76
to
fb10060
Compare
kevindew
approved these changes
Jul 27, 2020
alex-ju
force-pushed
the
allow-requests-from-all-domains
branch
from
July 27, 2020 17:07
df18543
to
9062b25
Compare
alex-ju
force-pushed
the
allow-requests-from-all-domains
branch
from
July 27, 2020 17:12
9062b25
to
d570889
Compare
alex-ju
force-pushed
the
allow-requests-from-all-domains
branch
from
July 27, 2020 17:18
d570889
to
fb10060
Compare
I got this failing in CI (on dev machine works fine) with:
It seems to be the case with any new PR. Tried to dig into it, but nothing that clicked. I've updated the test to the best of my knowledge to make it pass – it seemed to be caused by comparing different data types – still not sure that test is actually relevant after debugging it 🤷♂️ |
alex-ju
force-pushed
the
allow-requests-from-all-domains
branch
from
July 29, 2020 19:06
598a91e
to
3a0e49a
Compare
alex-ju
force-pushed
the
allow-requests-from-all-domains
branch
from
July 29, 2020 19:13
3a0e49a
to
7b29515
Compare
alex-ju
force-pushed
the
allow-requests-from-all-domains
branch
from
July 29, 2020 19:17
7b29515
to
0985c5a
Compare
alex-ju
force-pushed
the
allow-requests-from-all-domains
branch
from
July 29, 2020 19:18
0985c5a
to
771eab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allow requests for all domains e.g. .dev.gov.uk
Why
To allow local development and cross-browser/device testing in Browserstack
Visual Changes
No visual changes