Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow requests for all domains e.g. <app>.dev.gov.uk #1628

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

alex-ju
Copy link
Contributor

@alex-ju alex-ju commented Jul 27, 2020

What

Allow requests for all domains e.g. .dev.gov.uk

Why

To allow local development and cross-browser/device testing in Browserstack

Visual Changes

No visual changes

@bevanloon bevanloon temporarily deployed to govuk-publis-allow-requ-5ml5lb July 27, 2020 15:41 Inactive
@alex-ju alex-ju force-pushed the allow-requests-from-all-domains branch from ed2af76 to fb10060 Compare July 27, 2020 15:47
@bevanloon bevanloon temporarily deployed to govuk-publis-allow-requ-5ml5lb July 27, 2020 15:47 Inactive
@bevanloon bevanloon temporarily deployed to govuk-publis-allow-requ-5ml5lb July 27, 2020 17:06 Inactive
@alex-ju alex-ju force-pushed the allow-requests-from-all-domains branch from df18543 to 9062b25 Compare July 27, 2020 17:07
@bevanloon bevanloon temporarily deployed to govuk-publis-allow-requ-5ml5lb July 27, 2020 17:08 Inactive
@alex-ju alex-ju force-pushed the allow-requests-from-all-domains branch from 9062b25 to d570889 Compare July 27, 2020 17:12
@bevanloon bevanloon temporarily deployed to govuk-publis-allow-requ-5ml5lb July 27, 2020 17:13 Inactive
@alex-ju alex-ju force-pushed the allow-requests-from-all-domains branch from d570889 to fb10060 Compare July 27, 2020 17:18
@bevanloon bevanloon temporarily deployed to govuk-publis-allow-requ-5ml5lb July 27, 2020 17:19 Inactive
@alex-ju
Copy link
Contributor Author

alex-ju commented Jul 27, 2020

I got this failing in CI (on dev machine works fine) with:

1) GovukPublishingComponents::Presenters::HtmlPublicationSchema#structured_data behaves like an article
     Failure/Error: expect(structured_data["articleBody"]).to eq(page.body)
     # ./spec/lib/govuk_publishing_components/presenters/machine_readable/html_publication_schema_spec.rb:33:in `block (3 levels) in <top (required)>'

It seems to be the case with any new PR. Tried to dig into it, but nothing that clicked.

I've updated the test to the best of my knowledge to make it pass – it seemed to be caused by comparing different data types – still not sure that test is actually relevant after debugging it 🤷‍♂️

@bevanloon bevanloon temporarily deployed to govuk-publis-allow-requ-5ml5lb July 29, 2020 18:59 Inactive
@alex-ju alex-ju force-pushed the allow-requests-from-all-domains branch from 598a91e to 3a0e49a Compare July 29, 2020 19:06
@bevanloon bevanloon temporarily deployed to govuk-publis-allow-requ-5ml5lb July 29, 2020 19:06 Inactive
@alex-ju alex-ju force-pushed the allow-requests-from-all-domains branch from 3a0e49a to 7b29515 Compare July 29, 2020 19:13
@bevanloon bevanloon temporarily deployed to govuk-publis-allow-requ-5ml5lb July 29, 2020 19:14 Inactive
@alex-ju alex-ju force-pushed the allow-requests-from-all-domains branch from 7b29515 to 0985c5a Compare July 29, 2020 19:17
@bevanloon bevanloon temporarily deployed to govuk-publis-allow-requ-5ml5lb July 29, 2020 19:17 Inactive
@alex-ju alex-ju force-pushed the allow-requests-from-all-domains branch from 0985c5a to 771eab6 Compare July 29, 2020 19:18
@bevanloon bevanloon temporarily deployed to govuk-publis-allow-requ-5ml5lb July 29, 2020 19:19 Inactive
@alex-ju alex-ju merged commit 7317e1e into master Jul 29, 2020
@alex-ju alex-ju deleted the allow-requests-from-all-domains branch July 29, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants