Expand suggested sass ruby coverage #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- smart-answers includes ruby code that includes components inside /lib/ - without this change, the suggested sass functionality would have left portions of smart-answers unstyled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updating the
Suggested imports for this applicationfunctionality to include looking in the/libdirectory for component instances in ruby.Why
I was just converting
smart-answersto use individual component assets and noticed that bits of it were unstyled, because govspeak is included in files inside/lib. Haven't seen this before, smart-answers might be unique in this, but the change is still worth doing.Visual Changes
None.