Expand scope of suggested sass functionality #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- was previously looking for instances of component use only in the view, but government-frontend had one component call in a ruby helper, which was overlooked, resulting in an unstyled component - now includes all ruby files in /app/ when looking for components
andysellick
force-pushed
the
expand-suggested-sass
branch
from
9ba2a73 to
1da7c0a
Compare
|
The change itself looks good 👍 Does this have any impact on how quick the suggestions are to generate? |
vanitabarrett
approved these changes
Apr 22, 2020
|
@vanitabarrett good question. Probably. I've not measured it. I haven't noticed the component guide being slow since I implemented this change. If it is slow, or becomes slow, I'm happy to move this functionality off the guide homepage. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / why
Visual Changes
None