Remove redundant components import #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already import styles for components in each individual file so adding them here again inflates the scss and increased the compilation time unnecessarily
andysellick
approved these changes
Feb 28, 2020
| @@ -3,7 +3,6 @@ | |||
| // and everything else from govuk-frontend not included in govuk_frontend_support | |||
| @import "govuk/core/all"; | |||
| @import "govuk/objects/all"; | |||
| @import "govuk/components/all"; | |||
There was a problem hiding this comment.
Ohhhh... okay, I get it now. Great spot, thanks.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove
govuk/components/allfromcomponent_support.Why
We already import styles for components in each individual file so adding them in the
component_supportagain inflates the scss and increased the compilation time unnecessarily.Visual Changes
TBD