Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix changelog #1091

Merged
merged 3 commits into from
Sep 5, 2019
Merged

Fix changelog #1091

merged 3 commits into from
Sep 5, 2019

Conversation

alex-ju
Copy link
Contributor

@alex-ju alex-ju commented Sep 5, 2019 •
edited
Loading

What

  • Fix headings in changelog (one was an H1 and a couple were using a non-standards space resulting in plain text)
  • Add links to PRs consistently (GitHub doesn't automatically create links to PRs in markdown files for a while now, so we'll need to add these manually

Why

To make changelog more useful (and because I've been away for 2 weeks and now I realise how hard it is to get to the PRs)

@bevanloon bevanloon temporarily deployed to govuk-publishing-compo-pr-1091 September 5, 2019 10:29 Inactive
ChrisBAshton
ChrisBAshton reviewed Sep 5, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@bevanloon bevanloon temporarily deployed to govuk-publishing-compo-pr-1091 September 5, 2019 10:45 Inactive
ChrisBAshton
ChrisBAshton reviewed Sep 5, 2019
View reviewed changes
Copy link
Contributor

@ChrisBAshton ChrisBAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👏 just a couple of PRs missed.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
ChrisBAshton
ChrisBAshton approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@ChrisBAshton ChrisBAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🏅

@alex-ju alex-ju merged commit 14c878c into master Sep 5, 2019
@alex-ju alex-ju deleted the fix-changelog branch September 5, 2019 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanitabarrett vanitabarrett vanitabarrett approved these changes

@ChrisBAshton ChrisBAshton ChrisBAshton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alex-ju @ChrisBAshton @vanitabarrett @bevanloon